zhicheng233/PN532-Aime-Reader
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Add CI workflows for tag-based release publishing and per-commit DLL builds #1

Merged
Copilot merged 3 commits from copilot/add-action-for-tag-and-commit into master 2026-05-18 13:06:50 -04:00
Conversation 1 Commits 3 Files Changed 2 +103
2 changed files with 103 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
.github/workflows/build-on-commit.yml vendored Normal file
View File

@@ -0,0 +1,36 @@
name: Build NfcAime.Dll on Commit
on:
push:
tags-ignore:
- '*'
permissions:
contents: read
jobs:
build:
runs-on: windows-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup NuGet
uses: NuGet/setup-nuget@v2
- name: Setup MSBuild
uses: microsoft/setup-msbuild@v2
- name: Restore NuGet packages
run: nuget restore .\\PN532-Aime-Reader.sln
- name: Build NfcAime.Dll (x64, no project references)
run: msbuild .\\src\\NfcAime.Dll\\NfcAime.Dll.csproj /p:Configuration=Release /p:Platform="Any CPU" /p:PlatformTarget=x64 /p:BuildProjectReferences=false
copilot-pull-request-reviewer[bot] commented 2026-05-18 13:09:21 -04:00 (Migrated from github.com)
Review
Copy Link

Same issue as the release workflow: /p:Platform="Any CPU" likely won’t match the project’s Release|AnyCPU condition in NfcAime.Dll.csproj. This can lead to a non-Release configuration being effectively used and/or output landing somewhere other than the expected bin/Release path. Remove /p:Platform or change it to /p:Platform=AnyCPU.

Same issue as the release workflow: `/p:Platform="Any CPU"` likely won’t match the project’s `Release|AnyCPU` condition in `NfcAime.Dll.csproj`. This can lead to a non-Release configuration being effectively used and/or output landing somewhere other than the expected `bin/Release` path. Remove `/p:Platform` or change it to `/p:Platform=AnyCPU`.
- name: Upload build artifact
uses: actions/upload-artifact@v4
with:
name: NfcAime.Dll-${{ github.sha }}
path: src/NfcAime.Dll/bin/Release/NfcAime.Dll.dll
if-no-files-found: error

67
.github/workflows/release-on-tag.yml vendored Normal file
View File

@@ -0,0 +1,67 @@
name: Build and Release NfcAime.Dll on Tag
on:
push:
tags:
- '*'
permissions:
contents: write
jobs:
build-and-release:
runs-on: windows-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup NuGet
uses: NuGet/setup-nuget@v2
- name: Setup MSBuild
uses: microsoft/setup-msbuild@v2
- name: Restore NuGet packages
run: nuget restore .\\PN532-Aime-Reader.sln
- name: Build NfcAime.Dll (x64, no project references)
run: msbuild .\\src\\NfcAime.Dll\\NfcAime.Dll.csproj /p:Configuration=Release /p:Platform="Any CPU" /p:PlatformTarget=x64 /p:BuildProjectReferences=false
copilot-pull-request-reviewer[bot] commented 2026-05-18 13:09:20 -04:00 (Migrated from github.com)
Review
Copy Link

The MSBuild invocation passes /p:Platform="Any CPU", but NfcAime.Dll.csproj uses AnyCPU (no space) in its configuration conditions (e.g., Release|AnyCPU). With Platform="Any CPU", the intended Release property group may not apply (Optimize/DefineConstants/OutputPath), and the built DLL may not match the expected settings. Prefer removing /p:Platform entirely (letting the project default to AnyCPU) or set /p:Platform=AnyCPU.

This issue also appears on line 41 of the same file.

The MSBuild invocation passes `/p:Platform="Any CPU"`, but `NfcAime.Dll.csproj` uses `AnyCPU` (no space) in its configuration conditions (e.g., `Release|AnyCPU`). With `Platform="Any CPU"`, the intended Release property group may not apply (Optimize/DefineConstants/OutputPath), and the built DLL may not match the expected settings. Prefer removing `/p:Platform` entirely (letting the project default to AnyCPU) or set `/p:Platform=AnyCPU`. This issue also appears on line 41 of the same file.
- name: Generate commit notes since previous tag
shell: pwsh
run: |
$currentTag = "${{ github.ref_name }}"
$prevTag = git tag --sort=-creatordate | Where-Object { $_ -ne $currentTag } | Select-Object -First 1
if ($prevTag) {
$range = "$prevTag..$currentTag"
$commitTitle = "## Commits since $prevTag"
} else {
$range = $currentTag
$commitTitle = "## Commits in $currentTag"
}
$commits = git log $range --pretty=format:"- %s (%h)"
if (-not $commits) {
$commits = "- No commits found."
}
@"
## Build Artifact
- NfcAime.Dll.dll (Release, PlatformTarget=x64)
$commitTitle
$commits
"@ | Out-File -FilePath RELEASE_NOTES.md -Encoding utf8
- name: Create GitHub Release and upload DLL
uses: softprops/action-gh-release@v2
with:
tag_name: ${{ github.ref_name }}
body_path: RELEASE_NOTES.md
files: |
src/NfcAime.Dll/bin/Release/NfcAime.Dll.dll
fail_on_unmatched_files: true