zhicheng233/PN532-Aime-Reader
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Add CI workflows for tag-based release publishing and per-commit DLL builds #1

Merged
Copilot merged 3 commits from copilot/add-action-for-tag-and-commit into master 2026-05-18 13:06:50 -04:00
Conversation 1 Commits 3 Files Changed 2 +6 -3
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit dccc38eb4b - Show all commits

5
.github/workflows/build-on-commit.yml vendored
View File

@@ -5,6 +5,9 @@ on:
tags-ignore: tags-ignore:
- '*' - '*'
permissions:
contents: read
jobs: jobs:
build: build:
runs-on: windows-latest runs-on: windows-latest
@@ -23,7 +26,7 @@ jobs:
run: nuget restore .\\PN532-Aime-Reader.sln run: nuget restore .\\PN532-Aime-Reader.sln
- name: Build NfcAime.Dll (x64, no project references) - name: Build NfcAime.Dll (x64, no project references)
run: msbuild .\\src\\NfcAime.Dll\\NfcAime.Dll.csproj /p:Configuration=Release /p:Platform="Any CPU" /p:BuildProjectReferences=false run: msbuild .\\src\\NfcAime.Dll\\NfcAime.Dll.csproj /p:Configuration=Release /p:Platform="Any CPU" /p:PlatformTarget=x64 /p:BuildProjectReferences=false
copilot-pull-request-reviewer[bot] commented 2026-05-18 13:09:21 -04:00 (Migrated from github.com)
Review
Copy Link

Same issue as the release workflow: /p:Platform="Any CPU" likely won’t match the project’s Release|AnyCPU condition in NfcAime.Dll.csproj. This can lead to a non-Release configuration being effectively used and/or output landing somewhere other than the expected bin/Release path. Remove /p:Platform or change it to /p:Platform=AnyCPU.

Same issue as the release workflow: `/p:Platform="Any CPU"` likely won’t match the project’s `Release|AnyCPU` condition in `NfcAime.Dll.csproj`. This can lead to a non-Release configuration being effectively used and/or output landing somewhere other than the expected `bin/Release` path. Remove `/p:Platform` or change it to `/p:Platform=AnyCPU`.
- name: Upload build artifact - name: Upload build artifact
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v4

4
.github/workflows/release-on-tag.yml vendored
View File

@@ -28,7 +28,7 @@ jobs:
run: nuget restore .\\PN532-Aime-Reader.sln run: nuget restore .\\PN532-Aime-Reader.sln
- name: Build NfcAime.Dll (x64, no project references) - name: Build NfcAime.Dll (x64, no project references)
run: msbuild .\\src\\NfcAime.Dll\\NfcAime.Dll.csproj /p:Configuration=Release /p:Platform="Any CPU" /p:BuildProjectReferences=false run: msbuild .\\src\\NfcAime.Dll\\NfcAime.Dll.csproj /p:Configuration=Release /p:Platform="Any CPU" /p:PlatformTarget=x64 /p:BuildProjectReferences=false
copilot-pull-request-reviewer[bot] commented 2026-05-18 13:09:20 -04:00 (Migrated from github.com)
Review
Copy Link

The MSBuild invocation passes /p:Platform="Any CPU", but NfcAime.Dll.csproj uses AnyCPU (no space) in its configuration conditions (e.g., Release|AnyCPU). With Platform="Any CPU", the intended Release property group may not apply (Optimize/DefineConstants/OutputPath), and the built DLL may not match the expected settings. Prefer removing /p:Platform entirely (letting the project default to AnyCPU) or set /p:Platform=AnyCPU.

This issue also appears on line 41 of the same file.

The MSBuild invocation passes `/p:Platform="Any CPU"`, but `NfcAime.Dll.csproj` uses `AnyCPU` (no space) in its configuration conditions (e.g., `Release|AnyCPU`). With `Platform="Any CPU"`, the intended Release property group may not apply (Optimize/DefineConstants/OutputPath), and the built DLL may not match the expected settings. Prefer removing `/p:Platform` entirely (letting the project default to AnyCPU) or set `/p:Platform=AnyCPU`. This issue also appears on line 41 of the same file.
- name: Generate commit notes since previous tag - name: Generate commit notes since previous tag
shell: pwsh shell: pwsh
@@ -51,7 +51,7 @@ jobs:
@" @"
## Build Artifact ## Build Artifact
- NfcAime.Dll.dll (x64, Release) - NfcAime.Dll.dll (Release, PlatformTarget=x64)
$commitTitle $commitTitle
$commits $commits