From ee23914e293fb2721886339792648c0bd4c87f2d Mon Sep 17 00:00:00 2001 From: mokurin000 <1348292515a@gmail.com> Date: Wed, 17 Sep 2025 15:39:04 +0800 Subject: [PATCH] perf: reduce useless data read --- sdgb-cli/src/utils/helpers/mod.rs | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/sdgb-cli/src/utils/helpers/mod.rs b/sdgb-cli/src/utils/helpers/mod.rs index f73e9f0..726450e 100644 --- a/sdgb-cli/src/utils/helpers/mod.rs +++ b/sdgb-cli/src/utils/helpers/mod.rs @@ -169,10 +169,8 @@ where { let cache_table = cache::open_table_ro(&read, definition)?; let data = cache_table.get(user_id)?; - if let Some(data) = data { - let decoded: (R, _) = borrow_decode_from_slice(&data.value(), config)?; - - return Ok(decoded.0); + if data.is_some() { + return Ok(()); } } @@ -181,16 +179,14 @@ where } let resp = scrape(&client, user_id).await; - match &resp { Ok(resp) => { use sdgb_api::bincode::encode_to_vec; - info!("fetched: {user_id}"); - if let Ok(mut table) = cache::open_table(&write, definition) && let Ok(encoded) = encode_to_vec(resp, config) { + info!("encode length for {user_id}: {}", encoded.len()); _ = table.insert(user_id, encoded); } } @@ -200,10 +196,9 @@ where } } - Result::<_, Box>::Ok(resp?) + Result::<_, Box>::Ok(()) }) .buffer_unordered(concurrency) // slower to avoid being banned - .filter_map(async |r| r.ok()) .collect::>() .await; drop(collect);